gpt-5 support - #112
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughUpdates add gpt-5 handling to the OpenAI provider by aligning parameter logic with o4/o1, and adjust default model selections in credential resolution: OpenAI now defaults to gpt-5, and Anthropic to claude-sonnet-4-20250514. No public API signatures change. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant CLI as CLI get_credentials_v2
participant Cfg as Env/Config
User->>CLI: Invoke command (no model_string)
CLI->>Cfg: Read provider env/config
alt Provider = openai
CLI->>CLI: Set default model = openai:gpt-5
else Provider = anthropic
CLI->>CLI: Set default model = anthropic:claude-sonnet-4-20250514
end
CLI-->>User: Credentials + selected default model
sequenceDiagram
autonumber
participant Client as OpenAIProvider
participant Builder as _build_request
participant API as OpenAI API
Client->>Builder: Build chat/completions request (model, kwargs)
alt Model starts with o4/o1/gpt-5
note right of Builder: Uses max_completion_tokens<br/>Temperature defaults to 1.0 unless specified
Builder->>API: {model, messages, max_completion_tokens, (temperature?)}
else Other models
note right of Builder: Uses max_tokens<br/>Temperature from kwargs (default 0.0)
Builder->>API: {model, messages, max_tokens, temperature}
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (2)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit